feat: add workflows #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
joshuali925
reviewed
Nov 8, 2023
| - name: Run tests | ||
| run: | | ||
| cd OpenSearch-Dashboards/plugins/dashboards-assistant | ||
| yarn run test:jest --coverage |
There was a problem hiding this comment.
yarn test --coverage?
dashboards-assistant/package.json
Line 9 in 7477666
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/ci-flow
branch
from
d7127e9 to
cfc3e4d
Compare
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
|
@joshuali925 would you mind adding a approval for this PR so I can merge this PR. |
joshuali925
approved these changes
Nov 10, 2023
| }, | ||
| transformIgnorePatterns: ['<rootDir>/node_modules/(?!langchain|langsmith)'], | ||
| // https://github.com/jestjs/jest/issues/6229#issuecomment-403539460 | ||
| transformIgnorePatterns: ['node_modules/(?!langchain|langsmith)'], |
There was a problem hiding this comment.
any issue with ts-jest that we need to use babel?
There was a problem hiding this comment.
- There are a lot of warnings when using ts-jest because of version conflict.
- Both
ts-jestandbabel-jestshould work but
babel-jestis installed alongside jest- ts-jest requires extra configuration
- babel-jest is used in OSD and other plugins, not ts-jest.
ruanyl
pushed a commit
that referenced
this pull request
Nov 20, 2023
* Chat window header Signed-off-by: Hailong Cui <[email protected]> * support chat title Signed-off-by: Hailong Cui <[email protected]> * dock bottom and right icon update Signed-off-by: Hailong Cui <[email protected]> * chat window style Signed-off-by: Hailong Cui <[email protected]> * fix new conversation don't show when in trace page Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add workflows:
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.