feat: set verbose to false #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
xluo-aws,
gaobinlong,
Hailong-am,
wanglam and
raintygao
as code owners
|
@SuZhou-Joe Do we still need the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 48 48
Lines 1261 1261
Branches 312 312
=======================================
Hits 1206 1206
Misses 53 53
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
@wanglam We need the memoryId and interactionId, ml-commons has merged a PR to return memory id and interaction id when verbose is false. |
Signed-off-by: SuZhou-Joe <[email protected]>
wanglam
approved these changes
Feb 5, 2024
ruanyl
approved these changes
Feb 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
* feat: set verbose to false Signed-off-by: SuZhou-Joe <[email protected]> * feat: update doc Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 485138c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Feb 5, 2024
* feat: set verbose to false * feat: update doc --------- (cherry picked from commit 485138c) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opensearch-project/ml-commons#1988
Agent framework used to return memoryId and interactionId only when verbose is set to true. But when we set verbose to true, some useless message will be write into additional_info, which is unnecessary and may cause issue like too many payload was passed when updating a doc.
As now agent framework already merge the code to return both when verbose is false, we need to change the flag in Chatbot.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.