[OpenSearch Playground] Adds GitHub action file for deployment #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tao liu <[email protected]>
seraphjiang
reviewed
Jun 29, 2022
seraphjiang
reviewed
Jun 29, 2022
seraphjiang
approved these changes
Jun 29, 2022
zhongnansu
approved these changes
Jun 29, 2022
| - 'config/playground/helm/prod/**' | ||
|
|
||
| OS-OSD-Dev-Deployment: | ||
| if: ${{ needs.Pre-Deployment.outputs.config_change_dev == 'true'}} |
There was a problem hiding this comment.
I saw this has been used in many places, maybe consider making it an env variable if possible?
There was a problem hiding this comment.
We need to pass the environment variable to different jobs, not the same job. If we pass it in the same jobs, we can create a environment for it. the way that we pass the value to different jobs is leveraging outputs from job. the reference is here https://docs.github.com/en/actions/learn-github-actions/environment-variables#passing-values-between-steps-and-jobs-in-a-workflow
seraphjiang
pushed a commit
to seraphjiang/dashboards-anywhere
that referenced
this pull request
Oct 22, 2022
Signed-off-by: Tao liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tao liu [email protected]
Description
Adds GitHub action yml file, which was used for deploying OpenSearch and OpenSearch Dashboards.
NOTE, this PR is initial request for the action file, it didn't include the full deployment steps as Helm configuration file was not checked in, the related PR is here
Issues Resolved
Resolve #21
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.