Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Playground]Adds terraform eks configuration #20

Merged
merged 3 commits into from
Jun 20, 2022
Merged

[Playground]Adds terraform eks configuration #20

merged 3 commits into from
Jun 20, 2022

Conversation

Flyingliuhub
Copy link
Member

@Flyingliuhub Flyingliuhub commented Jun 16, 2022 •
edited
Loading

Description

Build AWS EKS cluster via terraform configuration. we can easily to build eks cluster via couple terraform commands based on our configuration.

// Current autoscaler for dev cluster
  scaling_config {
    desired_size = 1
    max_size     = 3
    min_size     = 1
  }

Issues Resolved

Resolve #10

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Flyingliuhub Flyingliuhub requested a review from a team June 16, 2022 23:29
@Flyingliuhub Flyingliuhub self-assigned this Jun 16, 2022
@seraphjiang seraphjiang added the enhancement New feature or request label Jun 17, 2022
@seraphjiang
Copy link
Member

seraphjiang commented Jun 17, 2022 •
edited
Loading

Could we add a doc to explain how to use these *.tf files. what are pre-requisite to run these tf files

seraphjiang
seraphjiang reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@seraphjiang seraphjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need doc to explain the input/output for the terraform config, how to use the tf file, when/where to use it.

@Flyingliuhub Flyingliuhub added the playgroud playground project label label Jun 17, 2022
@Flyingliuhub
adds readme file
14a5330 
Signed-off-by: Tao liu <[email protected]>
@Flyingliuhub
Copy link
Member Author

Could we add a doc to explain how to use these *.tf files. what are pre-requisite to run these tf files

Added the readme for the guide

@Flyingliuhub Flyingliuhub mentioned this pull request Jun 17, 2022
Merged
1 task
@Flyingliuhub Flyingliuhub requested a review from a team June 17, 2022 23:51
seraphjiang
seraphjiang approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@seraphjiang seraphjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

seraphjiang
seraphjiang reviewed Jun 18, 2022
View reviewed changes
config/playground/eks/dev/README.md Outdated Show resolved Hide resolved
config/playground/eks/dev/README.md Outdated Show resolved Hide resolved
config/playground/eks/dev/README.md Outdated Show resolved Hide resolved
@seraphjiang seraphjiang changed the title [Playground Dev]Adds terraform eks configuration [Playgroun]Adds terraform eks configuration Jun 18, 2022
@seraphjiang seraphjiang changed the title [Playgroun]Adds terraform eks configuration [Playground]Adds terraform eks configuration Jun 18, 2022
@Flyingliuhub
fixes comments
a2b0405 
Signed-off-by: Tao liu <[email protected]>
@Flyingliuhub Flyingliuhub requested a review from a team June 20, 2022 17:57
tianleh
tianleh reviewed Jun 20, 2022
View reviewed changes
config/playground/eks/dev/vpc.tf
#

resource "aws_vpc" "playground-dev" {
cidr_block = "10.0.0.0/16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonblocking: add a comment about how this value is decided.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that range is standard for AWS, I will add comment in the next PR.

tianleh
tianleh reviewed Jun 20, 2022
View reviewed changes
config/playground/eks/dev/workstation-external-ip.tf
#

data "http" "workstation-external-ip" {
url = "http://ipv4.icanhazip.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why not simply ifconfig command?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no special requirement for ipv4.icanhazip.com, it is recommended by terraform aws provider.

@Flyingliuhub Flyingliuhub merged commit 55b9d8b into main Jun 20, 2022
@Flyingliuhub Flyingliuhub deleted the liutaoeks branch June 21, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seraphjiang seraphjiang seraphjiang approved these changes

@tianleh tianleh tianleh approved these changes

Assignees

@Flyingliuhub Flyingliuhub

Labels
enhancement New feature or request playgroud playground project label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OpenSearch Playground] Prepare the Dev infra for the demo site
3 participants
@Flyingliuhub @seraphjiang @tianleh