-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish only ZIP artifacts since the plugin has no xxx-client counterpart #72
Conversation
…part Signed-off-by: Andriy Redko <[email protected]>
@gaiksaya fyi |
Hi @reta , The problematic pom was /org/opensearch/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.pom The one with the |
Correct @gaiksaya , it is gone now, we don't need to publish this JAR |
Hey @reta apart from what @gaiksaya said, lets not remove the jar publish as some users might directly use the Jar (import) and move forward with the development or use the jar to address dependencies. Example I can directly use the https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/opensearch-custom-codecs/2.10.0.0/
WDYT? |
Hey @prudhvigodithi , there is absolutely no need to use this JAR, some plugins do have xxx-client artifacts, this plugin has not, we should not publish just JAR for no reason. |
Sure @reta just bought it up to ensure we dont impact users who use jars. |
Thanks @prudhvigodithi , I see no circumstances under which the JAR could be useful as it is now. |
@andrross need your signoff please |
…part (#72) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit ac484d3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…part (#72) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit ac484d3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…part (#72) (#73) (cherry picked from commit ac484d3) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…part (#72) (#74) (cherry picked from commit ac484d3) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Publish only ZIP artifacts since the plugin has no xxx-client counterpart
Issues Resolved
Closes #68
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.