Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish only ZIP artifacts since the plugin has no xxx-client counterpart #72

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 4, 2023

Description

Publish only ZIP artifacts since the plugin has no xxx-client counterpart

$ ./scripts/build.sh -s true -v 3.0.0
$ tree build/local-staging-repo/org/opensearch/
build/local-staging-repo/org/opensearch/
└── plugin
    └── opensearch-custom-codecs
        ├── 3.0.0.0-SNAPSHOT
        │   ├── maven-metadata.xml
        │   ├── maven-metadata.xml.md5
        │   ├── maven-metadata.xml.sha1
        │   ├── maven-metadata.xml.sha256
        │   ├── maven-metadata.xml.sha512
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.pom
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.pom.md5
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.pom.sha1
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.pom.sha256
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.pom.sha512
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.zip
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.zip.md5
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.zip.sha1
        │   ├── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.zip.sha256
        │   └── opensearch-custom-codecs-3.0.0.0-20231004.151629-1.zip.sha512
        ├── maven-metadata.xml
        ├── maven-metadata.xml.md5
        ├── maven-metadata.xml.sha1
        ├── maven-metadata.xml.sha256
        └── maven-metadata.xml.sha512

Issues Resolved

Closes #68

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Oct 4, 2023

@gaiksaya fyi

@gaiksaya
Copy link
Member

gaiksaya commented Oct 4, 2023

@gaiksaya fyi

Hi @reta ,

The problematic pom was /org/opensearch/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.pom

The one with the plugin path in it was fine. Adding @prudhvigodithi here who helped me to fix this.

@reta
Copy link
Collaborator Author

reta commented Oct 4, 2023

The problematic pom was /org/opensearch/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.pom

Correct @gaiksaya , it is gone now, we don't need to publish this JAR

@prudhvigodithi
Copy link
Member

Hey @reta apart from what @gaiksaya said, lets not remove the jar publish as some users might directly use the Jar (import) and move forward with the development or use the jar to address dependencies. Example I can directly use the https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/opensearch-custom-codecs/2.10.0.0/

mvn org.apache.maven.plugins:maven-dependency-plugin:2.1:get -DrepoUrl=https://aws.oss.sonatype.org/content/repositories/releases/ -Dartifact=org.opensearch:opensearch-custom-codecs:2.10.0.0
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:2.1:get (default-cli) @ standalone-pom ---
Downloading from central: https://repo.maven.apache.org/maven2/org/opensearch/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.jar
Downloaded from central: https://repo.maven.apache.org/maven2/org/opensearch/opensearch-custom-codecs/2.10.0.0/opensearch-custom-codecs-2.10.0.0.jar (27 kB at 72 kB/s)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.800 s
[INFO] Finished at: 2023-10-04T10:15:10-07:00
[INFO] ------------------------------------------------------------------------

WDYT?
@bbarani @peterzhuamazon

@reta
Copy link
Collaborator Author

reta commented Oct 4, 2023

Hey @reta apart from what @gaiksaya said, lets not remove the jar publish as some users might directly use the Jar (import) and move forward with the development or use the jar to address dependencies.

Hey @prudhvigodithi , there is absolutely no need to use this JAR, some plugins do have xxx-client artifacts, this plugin has not, we should not publish just JAR for no reason.

@prudhvigodithi
Copy link
Member

Hey @prudhvigodithi , there is absolutely no need to use this JAR, some plugins do have xxx-client artifacts, this plugin has not, we should not publish just JAR for no reason.

Sure @reta just bought it up to ensure we dont impact users who use jars.

@reta
Copy link
Collaborator Author

reta commented Oct 4, 2023

Sure @reta just bought it up to ensure we dont impact users who use jars.

Thanks @prudhvigodithi , I see no circumstances under which the JAR could be useful as it is now.

@reta
Copy link
Collaborator Author

reta commented Oct 4, 2023

@andrross need your signoff please

@andrross andrross merged commit ac484d3 into opensearch-project:main Oct 4, 2023
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2023
…part (#72)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit ac484d3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2023
…part (#72)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit ac484d3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Oct 5, 2023
…part (#72) (#73)

(cherry picked from commit ac484d3)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Oct 5, 2023
…part (#72) (#74)

(cherry picked from commit ac484d3)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pom file is missing project description
4 participants