Sync settings #994
Sync settings #994
Conversation
Signed-off-by: monusingh-1 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
=============================================
+ Coverage 46.05% 70.55% +24.50%
- Complexity 633 1012 +379
=============================================
Files 141 141
Lines 4736 4809 +73
Branches 534 550 +16
=============================================
+ Hits 2181 3393 +1212
+ Misses 2291 1068 -1223
- Partials 264 348 +84
|
| @@ -26,14 +26,20 @@ import kotlinx.coroutines.asCoroutineDispatcher | |||
| import kotlinx.coroutines.launch | |||
| import org.apache.logging.log4j.LogManager | |||
| import org.opensearch.action.ActionListener | |||
| import org.opensearch.action.admin.indices.alias.IndicesAliasesRequest | |||
There was a problem hiding this comment.
Will remove unused imports in next commit.
monusingh-1
force-pushed
the
sync_settings1
branch
from
5b0a4ef to
1dc4516
Compare
Signed-off-by: monusingh-1 <[email protected]>
| @@ -166,6 +178,120 @@ class TransportReplayChangesAction @Inject constructor(settings: Settings, trans | |||
| return WriteReplicaResult(request, location, null, replicaShard, log) | |||
| } | |||
|
|
|||
| // fetches the index settings from the leader cluster and applies it to the local cluster's index settings. | |||
| private suspend fun syncRemoteSettings(leaderAlias: String, leaderIndex: String, followerIndex: String) { | |||
There was a problem hiding this comment.
Like discussed offline, let's use common logic between replay and index replication task for mapping and settings sync.
| @@ -166,6 +178,120 @@ class TransportReplayChangesAction @Inject constructor(settings: Settings, trans | |||
| return WriteReplicaResult(request, location, null, replicaShard, log) | |||
| } | |||
|
|
|||
| // fetches the index settings from the leader cluster and applies it to the local cluster's index settings. | |||
| private suspend fun syncRemoteSettings(leaderAlias: String, leaderIndex: String, followerIndex: String) { | |||
There was a problem hiding this comment.
This function is being added mainly to be able to update mappings which use analyzer defined in the settings.
We can reduce the scope of this function to just check if there is any change in the index.analysis.* settings and then update that. This way we can remove most of the logic of creating the settings and closing the index.
| @@ -124,6 +131,11 @@ class TransportReplayChangesAction @Inject constructor(settings: Settings, trans | |||
| var result = primaryShard.applyTranslogOperation(op, Engine.Operation.Origin.PRIMARY) | |||
| if (shouldSyncMappingAndRetry(result)) { | |||
| waitForMappingUpdate { | |||
| // fetch index settings from the leader cluster when applying on PRIMARY... | |||
| try{ | |||
There was a problem hiding this comment.
We should not catch the exception
Description
Sync settings when trying to update leader index metadata.
Issues Resolved
#992
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.