Handling exception in getAssignment method #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268)
Signed-off-by: Nishant Goel <[email protected]>
ankitkala
approved these changes
Jun 1, 2023
soosinha
approved these changes
Jun 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901)
This was referenced Jun 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901)
This was referenced Jun 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901)
ankitkala
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901) Co-authored-by: Nishant Goel <[email protected]>
ankitkala
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901) Co-authored-by: Nishant Goel <[email protected]>
This was referenced Jun 1, 2023
monusingh-1
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901) Co-authored-by: Nishant Goel <[email protected]>
monusingh-1
pushed a commit
that referenced
this pull request
Jun 2, 2023
* Handling exception in getAssignment method (#937) * Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]>
monusingh-1
pushed a commit
that referenced
this pull request
Jun 2, 2023
* Handling exception in getAssignment method (#937) * Handling exception in getAssignment method (#881) * Handling exception in getAssignment method Handling exception in getAssignment method Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> * Adding UT for getAssignment Method Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 14b9268) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 2c28901) * Fixing build Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getAssignment method is used to assign shard replication task via persistent task cluster service. In case of stale entries present in persistent tasks in cluster state when this method is trying to assign task it is not handled properly.
Most of the times stale entries are not present in cluster state as we are clearing them at the time of cancelling the replication task but if cancelling is failed by any reason then these entries can remain in the cluster state.
Issues Resolved
#880
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.