Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Handle clean-up of stale index task during cancellation (#645) #909

Merged
merged 1 commit into from
May 31, 2023
Merged

[Backport] Handle clean-up of stale index task during cancellation (#645) #909

merged 1 commit into from
May 31, 2023

Conversation

saikaranam-amazon
Copy link
Member

Description

[Backport] Handle clean-up of stale index task during cancellation

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saikaranam-amazon saikaranam-amazon marked this pull request as ready for review May 31, 2023 06:53
@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #909 (4f95717) into 2.x (8ef6451) will increase coverage by 0.53%.
The diff coverage is 56.52%.

❗ Current head 4f95717 differs from pull request most recent head 654571e. Consider uploading reports for the commit 654571e to get more accurate results

@@             Coverage Diff              @@
##                2.x     #909      +/-   ##
============================================
+ Coverage     72.91%   73.44%   +0.53%     
- Complexity     1001     1013      +12     
============================================
  Files           141      141              
  Lines          4678     4693      +15     
  Branches        514      521       +7     
============================================
+ Hits           3411     3447      +36     
+ Misses          944      922      -22     
- Partials        323      324       +1
Impacted Files Coverage Δ
...rch/replication/task/index/IndexReplicationTask.kt 68.07% <56.52%> (-0.27%) ⬇️

... and 5 files with indirect coverage changes

@saikaranam-amazon saikaranam-amazon merged commit 9e06f40 into opensearch-project:2.x May 31, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 31, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
@saikaranam-amazon @github-actions
[Backport] Handle clean-up of stale index task during cancellation (#645
0a56989 
) (#909)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 31, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
@saikaranam-amazon @github-actions
[Backport] Handle clean-up of stale index task during cancellation (#645
9e92cb3 
) (#909)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 31, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
@saikaranam-amazon @github-actions
[Backport] Handle clean-up of stale index task during cancellation (#645
dcd26b5 
) (#909)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
@saikaranam-amazon @github-actions
[Backport] Handle clean-up of stale index task during cancellation (#645
b8becb4 
) (#909)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 31, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
@saikaranam-amazon @github-actions
[Backport] Handle clean-up of stale index task during cancellation (#645
31d8444 
) (#909)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)
This was referenced May 31, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
@saikaranam-amazon @github-actions
[Backport] Handle clean-up of stale index task during cancellation (#645
9f2b332 
) (#909)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 31, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
@saikaranam-amazon @github-actions
[Backport] Handle clean-up of stale index task during cancellation (#645
70e172f 
) (#909)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)
ankitkala pushed a commit that referenced this pull request May 31, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (#645
a75ef19 
) (#909) (#913)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
ankitkala pushed a commit that referenced this pull request May 31, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (#645
af2b001 
) (#909) (#914)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
ankitkala pushed a commit that referenced this pull request May 31, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (#645
0cf437a 
) (#909) (#915)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
ankitkala pushed a commit that referenced this pull request May 31, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (#645
289f4b0 
) (#909) (#916)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
ankitkala pushed a commit that referenced this pull request May 31, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (#645
e1fbaa9 
) (#909) (#917)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
ankitkala pushed a commit that referenced this pull request May 31, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (#645
5abfc6e 
) (#909) (#918)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
ankitkala pushed a commit that referenced this pull request May 31, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (#645
8c51043 
) (#909) (#919)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit to saikaranam-amazon/cross-cluster-replication-2 that referenced this pull request Jun 1, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (o…
0757b62 
…pensearch-project#645) (opensearch-project#909) (opensearch-project#913)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit to saikaranam-amazon/cross-cluster-replication-2 that referenced this pull request Jun 1, 2023
@opensearch-trigger-bot @saikaranam-amazon
[Backport] Handle clean-up of stale index task during cancellation (o…
da44d34 
…pensearch-project#645) (opensearch-project#909) (opensearch-project#913)

Signed-off-by: Sai Kumar <[email protected]>
(cherry picked from commit 9e06f40)

Co-authored-by: Sai Kumar <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Jun 2, 2023
@saikaranam-amazon @opensearch-trigger-bot
[Backport] Handle clean-up of stale index task during cancellation (#645
f459f0c 
) (#909) (#913) (#934)

(cherry picked from commit 9e06f40)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosinha soosinha soosinha approved these changes

@ankitkala ankitkala ankitkala approved these changes

Assignees
No one assigned
Labels
backport 1.1 backport 1.2 backport 1.3 backport 2.3 backport 2.5 backport 2.7 backport 2.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saikaranam-amazon @ankitkala @soosinha