Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh dependencies #899

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

monusingh-1
Copy link
Collaborator

Description

Github workflow runs everytime there is a commit push, in case of PR, the dependencies dont refresh when there is upstream changes leading to workflow runs with stale dependencies.

The option --refresh-dependencies tells Gradle to ignore all cached entries for resolved modules and artifacts

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Monu Singh <[email protected]>
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #899 (10f9ac8) into main (3e3787d) will increase coverage by 0.61%.
The diff coverage is 100.00%.

❗ Current head 10f9ac8 differs from pull request most recent head 6e2352b. Consider uploading reports for the commit 6e2352b to get more accurate results

@@             Coverage Diff              @@
##               main     #899      +/-   ##
============================================
+ Coverage     72.39%   73.01%   +0.61%     
- Complexity     1007     1014       +7     
============================================
  Files           141      141              
  Lines          4695     4695              
  Branches        527      527              
============================================
+ Hits           3399     3428      +29     
+ Misses          963      940      -23     
+ Partials        333      327       -6     
Impacted Files Coverage Δ
...arch/replication/task/autofollow/AutoFollowTask.kt 74.05% <100.00%> (+1.26%) ⬆️

... and 6 files with indirect coverage changes

@monusingh-1 monusingh-1 marked this pull request as ready for review June 2, 2023 04:49
@monusingh-1 monusingh-1 enabled auto-merge (squash) June 20, 2023 06:40
@monusingh-1 monusingh-1 merged commit d66a721 into opensearch-project:main Jun 20, 2023
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-899-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d66a7210f89b752f88573960a3b82c36697d8e32
# Push it to GitHub
git push --set-upstream origin backport/backport-899-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-899-to-2.x.

@monusingh-1 monusingh-1 deleted the refresh_dependency branch November 2, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants