[backport 1.1] Replication auto pauses on follower cluster having wait_for_active_shards true #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch-project#888) Github-Issue-544:Replication auto pauses on follower cluster having w… (cherry picked from commit 2fba1f7) Signed-off-by: Monu Singh <[email protected]> Co-authored-by: Priyanka Sharma <[email protected]>
Signed-off-by: Monu Singh <[email protected]>
monusingh-1
changed the title
monusingh-1
changed the title
saikaranam-amazon
approved these changes
May 29, 2023
ankitkala
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The leader index setting "wait_for_active_shards" is not copied/applied on the follower cluster. The default value of said setting is assumed at the follower cluster unless specified or changed specifically for the follower cluster.
Following is the expected behaviour in the identified scenarios relating to the "wait_for_active_shards" index setting,
If the wait_for_active_shards setting is set to “all” during index creation, the index replication will succeed but the said setting will not be copied to the follower cluster(Verify through the “_settings” API). If one of the follower node goes down, the replication should still continue.
If the wait_for_active_shards setting is set to “all” during index creation, and is later changed dynamically to any other valid value, on applying replication again, replication should not be affected and the setting value should also not change on the follower-cluster.
If the wait_for_active_shards setting is set to “default/any valid value”, and later changed to “all”, then the setting change should be ignored at the follower-cluster. No change in replication or the said setting's value.
NOTE- In all the above cases, the setting “wait_for_active_shards” value should be “default” on the follower-cluster.
If the follower index setting "wait_for_active_shards" is set to valid value in “start-replication” API, then that should be applied to the follower cluster.
If the follower index setting "wait_for_active_shards" is set to valid value in “update-settings” API for the follower cluster, then that should be applied on the follower cluster.
Issues Resolved
#544