Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if replication is not enabled on the remote domain #86

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

varunsrivathsav
Copy link
Contributor

Description

If replication is installed on the remote domain, currently the start API fails with ActionNotFoundTransportException. This CR is to surface an explicit message to say that the remote does not have replication enabled

Testing

Tested it on a setup with remote cluster without replication artefacts.

{
    "error": {
        "root_cause": [
            {
                "type": "unsupported_operation_exception",
                "reason": "Replication is not enabled on the remote domain"
            }
        ],
        "type": "unsupported_operation_exception",
        "reason": "Replication is not enabled on the remote domain"
    },
    "status": 500
}

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@saikaranam-amazon saikaranam-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunsrivathsav varunsrivathsav merged commit c6b292f into main Aug 4, 2021
@varunsrivathsav varunsrivathsav deleted the repl-nosupport branch August 11, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants