Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] handling null pointer exception in multi-filed mapping #787

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

@opensearch-trigger-bot opensearch-trigger-bot bot commented Apr 14, 2023

Description

Backport 501bd28 from #757
When replication started from leader index to follower followe index with empty data (empty mapping). It throws null pointer exception in multi-field mapping. This issue as such don't create any pause but mapping source, mapping properties variables are not nullable earlier were made nullable to stop throwing these errors.

Issues Resolved

nullPointerException while calling leader mapping source.
#622

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team April 14, 2023 05:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #787 (28821b8) into 2.0 (49cad2b) will increase coverage by 0.28%.
The diff coverage is 60.00%.

❗ Current head 28821b8 differs from pull request most recent head ddfc852. Consider uploading reports for the commit ddfc852 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.0     #787      +/-   ##
============================================
+ Coverage     74.39%   74.68%   +0.28%     
- Complexity     1007     1012       +5     
============================================
  Files           141      141              
  Lines          4613     4613              
  Branches        512      512              
============================================
+ Hits           3432     3445      +13     
+ Misses          862      847      -15     
- Partials        319      321       +2     
Impacted Files Coverage Δ
...rch/replication/task/index/IndexReplicationTask.kt 72.21% <60.00%> (+0.43%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* handling null pointer exception in multi-filed mapping

Signed-off-by: sricharanvuppu <[email protected]>
(cherry picked from commit 501bd28)
Signed-off-by: sricharanvuppu <[email protected]>
@sricharanvuppu sricharanvuppu force-pushed the backport/backport-757-to-2.0 branch from 0301876 to ddfc852 Compare April 14, 2023 08:26
@sricharanvuppu sricharanvuppu merged commit d78b7dc into 2.0 Apr 14, 2023
@sricharanvuppu sricharanvuppu deleted the backport/backport-757-to-2.0 branch April 14, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants