Integ test: forcemerge and snapshot on leader during bootstrap #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-ggk
reviewed
Aug 2, 2021
Comment on lines
+761
to
+847
| try { | ||
| followerClient.startReplication(StartReplicationRequest("source", leaderIndexName, followerIndexName), | ||
| TimeValue.timeValueSeconds(10), | ||
| false) | ||
| //Given the size of index, the replication should be in RESTORING phase at this point | ||
| leaderClient.indices().forcemerge(ForceMergeRequest(leaderIndexName), RequestOptions.DEFAULT) |
There was a problem hiding this comment.
Would replication chunk size give us better probability of assurance? We can set that to a small number and be assured it worked, and we can probably increase it too to later complete the test faster.
There was a problem hiding this comment.
How long do these take approximately?
It takes approx 30 sec for this test: around 10 sec to fill index with data and around 10 sec to verify the document count at follower side.
There was a problem hiding this comment.
The suggested setting plugins.replication.index.recovery.chunk_size takes min value as 1MB. So it is not possible to set a small chunk size like 1B. With 1MB chunk size, we still need to index large amount of data.
krishna-ggk
previously approved these changes
Aug 5, 2021
Signed-off-by: Sooraj Sinha <[email protected]>
soosinha
dismissed stale reviews from krishna-ggk and naveenpajjuri
via
fb55e8a
naveenpajjuri
approved these changes
Aug 6, 2021
krishna-ggk
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integ tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.