changed few naming conventions. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-ggk
reviewed
Aug 2, 2021
...lin/com/amazon/elasticsearch/replication/action/autofollow/UpdateAutoFollowPatternRequest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/amazon/elasticsearch/replication/task/index/IndexReplicationParams.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/amazon/elasticsearch/replication/task/index/IndexReplicationParams.kt
Outdated
Show resolved
Hide resolved
naveenpajjuri
force-pushed
the
naming_change
branch
2 times, most recently
from
3425e50 to
87e1c90
Compare
saikaranam-amazon
previously approved these changes
Aug 4, 2021
krishna-ggk
reviewed
Aug 9, 2021
| RemoteClusterRestoreLeaderService::class.java, RemoteClusterTranslogService::class.java) | ||
| LeaderClusterRestoreLeaderService::class.java, LeaderClusterTranslogService::class.java) |
There was a problem hiding this comment.
This should remain IMO as it is more of a remote cluster accessor. We just happen to use it to reference leader cluster.
There was a problem hiding this comment.
Reverted to RemoteClusterRestoreLeaderService and RemoteClusterTranslogService
Comment on lines
282
to
289
| val remoteShardRouting = leaderClusterState.routingTable.shardRoutingTable(snapshotShardId.indexName, | ||
| snapshotShardId.id).primaryShard() | ||
| remoteShardNode = remoteClusterState.nodes.get(remoteShardRouting.currentNodeId()) | ||
| // Get the index UUID of the remote cluster for the metadata request | ||
| remoteShardNode = leaderClusterState.nodes.get(remoteShardRouting.currentNodeId()) | ||
| // Get the index UUID of the leader cluster for the metadata request | ||
| remoteShardId = ShardId(snapshotShardId.indexName, | ||
| remoteClusterState.metadata.index(indexId.name).indexUUID, | ||
| leaderClusterState.metadata.index(indexId.name).indexUUID, | ||
| snapshotShardId.id) | ||
| restoreUUID = UUIDs.randomBase64UUID() |
There was a problem hiding this comment.
Can we rename remoteShardId and remoteShardNode as well?
soosinha
force-pushed
the
naming_change
branch
2 times, most recently
from
b6a299f to
cef0322
Compare
1. remote to leader, 2. local to follower, etc Signed-off-by: naveen pajjuri <[email protected]>
krishna-ggk
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: naveen pajjuri [email protected]
Description
changed the naming convention from remote --> leader and local --> follower.
Testing
Ran all the integration tests.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.