Integ test: Verify that replication is paused when remote index is deleted #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
naveenpajjuri
previously approved these changes
Aug 2, 2021
krishna-ggk
reviewed
Aug 2, 2021
Comment on lines
111
to
119
| try { | ||
| return suspendExecute(replicationMetadata, action, req, defaultContext = defaultContext) | ||
| } catch (e: ElasticsearchException) { | ||
| if (retryOn.contains(e.javaClass) || TransportActions.isShardNotAvailableException(e)) { | ||
| // Not retrying for IndexNotFoundException as it is not a transient failure | ||
| if (e !is IndexNotFoundException && (retryOn.contains(e.javaClass) || TransportActions.isShardNotAvailableException(e))) { | ||
| log.warn("Encountered a failure while executing in $req. Retrying in ${currentBackoff/1000} seconds" + | ||
| ".", e) | ||
| delay(currentBackoff) |
There was a problem hiding this comment.
Given this is a generic utility method, it feels incorrect to filter out exceptions here.
Shouldn't we be fixing the caller to not pass IndexNotFoundException here?
(We should also fix that isShartNotAvailableException, but one step at a time)
There was a problem hiding this comment.
We do not want to retry in case of IndexNotFoundException for all code paths to this method.
IndexNotFoundException is not passed by the caller. It is one of exceptions in TransportActions.isShardNotAvailableException which is part of core ES.
There was a problem hiding this comment.
Created an issue and added a TODO
…leted Signed-off-by: Sooraj Sinha <[email protected]>
soosinha
force-pushed
the
t-delete-idx-pause
branch
from
5c36b8b to
bb129cd
Compare
soosinha
changed the title
krishna-ggk
approved these changes
Aug 2, 2021
naveenpajjuri
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding integ test to check that replication gets paused if remote cluster is unavailable.
IndexNotFoundExceptionis being excluded from retry logic as this is a permanent failure otherwise we would need to wait for 2-3 min(due to exponential backoff) for replication to get paused.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.