Prevent starting replication directly on the leader index alias. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-ggk
commented
Jul 28, 2021
Comment on lines
+267
to
+283
| try { | ||
| followerClient.startReplication(StartReplicationRequest("source", "leaderAlias", followerIndexName)) | ||
| fail("Expected startReplication to fail") | ||
| } catch (e: ResponseException) { | ||
| assertThat(e.response.statusLine.statusCode).isEqualTo(404) | ||
| assertThat(e.message).contains("index_not_found_exception") | ||
| assertThat(e.message).contains("no such index [leaderAlias]") | ||
| } | ||
| } |
There was a problem hiding this comment.
I didn't use assertThatThrownBy since it didn't provide flexibility to extract statusCode.
(This was previously resulting in NPE) The rationale is to avoid complexity for now since an alias can be associated with multiple indices, although an extension could be to allow replication if there is a single match. Added an integration test to validate the case. While at it, also expanded BasicReplicationIT to incorporate force merge and ensure that doesn't impact replication. Signed-off-by: Gopala Krishna Ambareesh <[email protected]>
krishna-ggk
commented
Jul 28, 2021
| val waitMillis = Duration.ofMinutes(1).toMillis() | ||
| val waitMillis = Duration.ofMinutes(10).toMillis() |
There was a problem hiding this comment.
Also sneaking in this change - we felt 1 min might be too low.
gbbafna
approved these changes
Jul 28, 2021
soosinha
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent starting replication directly on the leader index alias.
(This was previously resulting in NPE)
The rationale is to avoid complexity for now since an alias can be
associated with multiple indices, although an extension could be to
allow replication if there is a single match.
Added an integration test to validate the case.
While at it, also expanded BasicReplicationIT to incorporate force merge
and ensure that doesn't impact replication.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.