Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Include default index settings during leader setting validation (#601) #609

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

ankitkala
Copy link
Member

Signed-off-by: Ankit Kala [email protected]

Signed-off-by: Ankit Kala [email protected]
(cherry picked from commit 67a7073)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
@ankitkala ankitkala requested a review from a team October 28, 2022 06:14
@codecov-commenter
Copy link

Codecov Report

Merging #609 (425d69c) into 1.x (98cf601) will decrease coverage by 1.21%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##                1.x     #609      +/-   ##
============================================
- Coverage     71.32%   70.10%   -1.22%     
+ Complexity      900      889      -11     
============================================
  Files           139      139              
  Lines          4453     4459       +6     
  Branches        525      526       +1     
============================================
- Hits           3176     3126      -50     
- Misses          956      998      +42     
- Partials        321      335      +14     
Impacted Files Coverage Δ
...tion/action/index/TransportReplicateIndexAction.kt 72.41% <63.63%> (-2.59%) ⬇️
...rch/replication/action/status/ShardInfoResponse.kt 36.52% <0.00%> (-38.27%) ⬇️
...arch/replication/metadata/UpdateMetadataRequest.kt 76.19% <0.00%> (-23.81%) ⬇️
.../action/status/TransportReplicationStatusAction.kt 76.66% <0.00%> (-17.78%) ⬇️
...lication/action/status/TranportShardsInfoAction.kt 82.75% <0.00%> (-13.80%) ⬇️
...ication/action/status/ReplicationStatusResponse.kt 57.14% <0.00%> (-5.36%) ⬇️
...replication/metadata/ReplicationMetadataManager.kt 63.26% <0.00%> (-2.05%) ⬇️
...rch/replication/task/index/IndexReplicationTask.kt 69.76% <0.00%> (+0.23%) ⬆️
...ation/task/shard/ShardReplicationChangesTracker.kt 63.63% <0.00%> (+3.03%) ⬆️
...tion/action/replay/TransportReplayChangesAction.kt 78.65% <0.00%> (+12.35%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ankitkala ankitkala changed the title Include default index settings during leader setting validation (#601) [Backport] Include default index settings during leader setting validation (#601) Oct 28, 2022
@ankitkala ankitkala merged commit 198e38b into 1.x Oct 28, 2022
@github-actions github-actions bot deleted the backport/backport-601-to-1.x branch October 28, 2022 06:41
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
#609)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
#609)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
#609)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
#609)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
#609)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)
ankitkala added a commit that referenced this pull request Oct 28, 2022
#609) (#610)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)

Co-authored-by: Ankit Kala <[email protected]>
ankitkala added a commit that referenced this pull request Oct 28, 2022
#609) (#611)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)

Co-authored-by: Ankit Kala <[email protected]>
ankitkala added a commit that referenced this pull request Oct 28, 2022
#609) (#612)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)

Co-authored-by: Ankit Kala <[email protected]>
ankitkala added a commit that referenced this pull request Oct 28, 2022
#609) (#613)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)

Co-authored-by: Ankit Kala <[email protected]>
ankitkala added a commit that referenced this pull request Oct 28, 2022
#609) (#614)

Signed-off-by: Ankit Kala <[email protected]>

Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 67a7073)
(cherry picked from commit 198e38b)

Co-authored-by: Ankit Kala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants