Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed version of jackson databind to 2.13.4.2 for OS 1.3 #608

Conversation

mohitamg
Copy link
Contributor

Signed-off-by: Mohit Kumar [email protected]

Description

Changed jackson databind version to 2.13.4.2 for Opensearch 1.3

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mohitamg mohitamg requested a review from a team October 28, 2022 04:46
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #608 (804d4b1) into 1.3 (e7dfc1b) will increase coverage by 0.67%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #608      +/-   ##
============================================
+ Coverage     74.28%   74.95%   +0.67%     
- Complexity     1001     1006       +5     
============================================
  Files           141      141              
  Lines          4584     4584              
  Branches        506      506              
============================================
+ Hits           3405     3436      +31     
+ Misses          865      838      -27     
+ Partials        314      310       -4     
Impacted Files Coverage Δ
...arch/replication/task/autofollow/AutoFollowTask.kt 73.85% <0.00%> (-2.62%) ⬇️
...rch/replication/task/index/IndexReplicationTask.kt 70.87% <0.00%> (-0.23%) ⬇️
...ation/task/shard/ShardReplicationChangesTracker.kt 63.63% <0.00%> (+3.03%) ⬆️
...earch/replication/metadata/UpdateIndexBlockTask.kt 77.41% <0.00%> (+3.22%) ⬆️
...tion/action/replay/TransportReplayChangesAction.kt 80.43% <0.00%> (+11.95%) ⬆️
...cation/action/changes/TransportGetChangesAction.kt 84.12% <0.00%> (+20.63%) ⬆️
.../replication/action/replay/ReplayChangesRequest.kt 100.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mohitamg mohitamg merged commit 1976192 into opensearch-project:1.3 Oct 28, 2022
@mohitamg mohitamg deleted the jackson-databind-version-change-for-1.3 branch October 28, 2022 07:03
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-608-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1976192f93541ddcbcda354aa3812d6452e0599b
# Push it to GitHub
git push --set-upstream origin backport/backport-608-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-608-to-1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants