-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parallel reader and writer for ShardReplicationTask #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-ggk
previously approved these changes
Jul 13, 2021
...ain/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationChangesTracker.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationChangesTracker.kt
Outdated
Show resolved
Hide resolved
ankitkala
force-pushed
the
parallel_reader
branch
from
July 13, 2021 09:34
9cbc406
to
e736158
Compare
...ain/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationChangesTracker.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationTask.kt
Show resolved
Hide resolved
src/main/kotlin/com/amazon/elasticsearch/replication/task/shard/TranslogSequencer.kt
Show resolved
Hide resolved
rushiagr
suggested changes
Jul 13, 2021
src/main/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationTask.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationTask.kt
Show resolved
Hide resolved
...ain/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationChangesTracker.kt
Show resolved
Hide resolved
...ain/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationChangesTracker.kt
Show resolved
Hide resolved
ankitkala
force-pushed
the
parallel_reader
branch
2 times, most recently
from
July 13, 2021 10:13
975d90f
to
0afea22
Compare
rushiagr
previously approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment regarding removing unused variable.
src/main/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationTask.kt
Show resolved
Hide resolved
src/main/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationTask.kt
Outdated
Show resolved
Hide resolved
krishna-ggk
previously approved these changes
Jul 13, 2021
src/main/kotlin/com/amazon/elasticsearch/replication/ReplicationPlugin.kt
Show resolved
Hide resolved
...ain/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationChangesTracker.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationTask.kt
Outdated
Show resolved
Hide resolved
saikaranam-amazon
previously approved these changes
Jul 13, 2021
...ain/kotlin/com/amazon/elasticsearch/replication/task/shard/ShardReplicationChangesTracker.kt
Outdated
Show resolved
Hide resolved
ankitkala
dismissed stale reviews from saikaranam-amazon, krishna-ggk, and rushiagr
via
July 13, 2021 10:44
76d28c3
ankitkala
force-pushed
the
parallel_reader
branch
5 times, most recently
from
July 13, 2021 11:29
72ab9e4
to
120dbe7
Compare
rushiagr
previously approved these changes
Jul 13, 2021
ankitkala
force-pushed
the
parallel_reader
branch
from
July 13, 2021 12:01
120dbe7
to
a9c8200
Compare
saikaranam-amazon
approved these changes
Jul 13, 2021
rushiagr
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for parallel reader and writer for ShardReplicationTask
Unit tests will be updated in a follow up CR