Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adding Index Settings validation before starting replication #470

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 93b43f4 from #461

* Adding Index Settings validation before starting replication

Signed-off-by: Gaurav Bafna <[email protected]>

* Retrieving default index settings before starting replication

Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit 93b43f4)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team August 3, 2022 11:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #470 (e1eaf54) into 2.x (5ab5469) will decrease coverage by 2.89%.
The diff coverage is 100.00%.

❗ Current head e1eaf54 differs from pull request most recent head 1a1a2e4. Consider uploading reports for the commit 1a1a2e4 to get more accurate results

@@             Coverage Diff              @@
##                2.x     #470      +/-   ##
============================================
- Coverage     73.32%   70.43%   -2.90%     
+ Complexity      985      944      -41     
============================================
  Files           141      141              
  Lines          4562     4576      +14     
  Branches        504      506       +2     
============================================
- Hits           3345     3223     -122     
- Misses          905     1034     +129     
- Partials        312      319       +7     
Impacted Files Coverage Δ
...tion/action/index/TransportReplicateIndexAction.kt 76.66% <100.00%> (+2.59%) ⬆️
.../org/opensearch/replication/util/ValidationUtil.kt 62.74% <100.00%> (+6.93%) ⬆️
...earch/replication/action/stats/NodeStatsRequest.kt 33.33% <0.00%> (-66.67%) ⬇️
...arch/replication/metadata/UpdateMetadataRequest.kt 40.90% <0.00%> (-59.10%) ⬇️
...eplication/action/stats/LeaderNodeStatsResponse.kt 42.85% <0.00%> (-57.15%) ⬇️
.../replication/action/replay/ReplayChangesRequest.kt 50.00% <0.00%> (-50.00%) ⬇️
...replication/action/index/ReplicateIndexResponse.kt 33.33% <0.00%> (-33.34%) ⬇️
...tion/action/index/block/UpdateIndexBlockRequest.kt 35.00% <0.00%> (-30.00%) ⬇️
...replication/action/stats/AutoFollowStatsRequest.kt 71.42% <0.00%> (-28.58%) ⬇️
...opensearch/replication/seqno/RemoteClusterStats.kt 73.01% <0.00%> (-26.99%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@gbbafna gbbafna merged commit 9a0d798 into 2.x Aug 3, 2022
@gbbafna gbbafna deleted the backport/backport-461-to-2.x branch August 3, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants