Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the published zip for security plugin #455

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Use the published zip for security plugin #455

merged 1 commit into from
Jul 19, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Jul 18, 2022 •
edited
Loading

Signed-off-by: Ankit Kala [email protected]

Description

Use the published zip for security plugin

Issues Resolved

274

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala marked this pull request as ready for review July 18, 2022 13:46
@ankitkala ankitkala requested a review from a team July 18, 2022 13:46
@ankitkala ankitkala merged commit 27898e2 into opensearch-project:main Jul 19, 2022
@ankitkala ankitkala deleted the security-zip branch July 19, 2022 04:29
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2022
@ankitkala @github-actions
Use the published zip for security plugin (#455)
276ab6e 
Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 27898e2)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 19, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2022
@ankitkala @github-actions
Use the published zip for security plugin (#455)
4d18a23 
Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 27898e2)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 19, 2022
Merged
ankitkala added a commit that referenced this pull request Jul 19, 2022
@opensearch-trigger-bot @ankitkala
Use the published zip for security plugin (#455) (#457)
5ab5469 
Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 27898e2)

Co-authored-by: Ankit Kala <[email protected]>
ankitkala added a commit that referenced this pull request Jul 19, 2022
@opensearch-trigger-bot @ankitkala
Use the published zip for security plugin (#455) (#456)
6324156 
Signed-off-by: Ankit Kala <[email protected]>
(cherry picked from commit 27898e2)

Co-authored-by: Ankit Kala <[email protected]>
@rursprung
Copy link
Contributor

as it's published to maven i don't understand why you don't pull it in as a maven artifact?!

@ankitkala
Copy link
Member Author

as it's published to maven i don't understand why you don't pull it in as a maven artifact?!

@rursprung No particular reason as such. Do you see any benefits of fetching from maven instead?

@rursprung
Copy link
Contributor

as it's published to maven i don't understand why you don't pull it in as a maven artifact?!

@rursprung No particular reason as such. Do you see any benefits of fetching from maven instead?

it'd (greatly) simplify your code as you wouldn't have to construct URLs but would just specify it like any other dependeny

@ankitkala
Copy link
Member Author

as it's published to maven i don't understand why you don't pull it in as a maven artifact?!

@rursprung No particular reason as such. Do you see any benefits of fetching from maven instead?

it'd (greatly) simplify your code as you wouldn't have to construct URLs but would just specify it like any other dependeny

Thanks. If you can share some sample that'd be great.
We basically configure the testcluster with security plugin zip(here) via a Callable<RegularFile> provider which will return a locally downloaded zip. I think even with maven, we'll need to do the same right?

@rursprung rursprung mentioned this pull request Sep 20, 2022
Merged
5 tasks
ankitkala pushed a commit that referenced this pull request Sep 26, 2022
@rursprung
use proper gradle dep. to fetch security plugin (#566)
e1dc511 
there's no need to manually construct a URL and try to fetch the
artefact from there. the plugin is published on maven and we can
directly use the gradle/maven dependency to fetch it.

in order to more easily identify it, a new configuration type has been
added: `opensearchPlugin`.

for reference see the discussions on the following issues/PRs:
- #274
- #455

Signed-off-by: Ralph Ursprung <[email protected]>

Signed-off-by: Ralph Ursprung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@saikaranam-amazon saikaranam-amazon saikaranam-amazon approved these changes

Assignees
No one assigned
Labels
backport 2.x backport 2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankitkala @rursprung @saikaranam-amazon @gbbafna