Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated kotlin version based on whitesource recommendation #448

Merged

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Jul 11, 2022

Description

Updated kotlin version based on whitesource recommendation

  • Forced jacoco version to 0.8.7 to work with the updated kotlin version.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saikaranam-amazon
Copy link
Member Author

security plugin load issue: opensearch-project/security#1934

@saikaranam-amazon
Copy link
Member Author

seeing jacoco test report generation failures - resulting in CI failures

* What went wrong:
Execution failed for task ':jacocoTestReport'.
> Error while creating report

@saikaranam-amazon saikaranam-amazon marked this pull request as ready for review July 11, 2022 14:44
@saikaranam-amazon saikaranam-amazon requested a review from a team July 11, 2022 14:44
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -178,6 +179,7 @@ abstract class CrossClusterReplicationTask(id: Long, type: String, action: Strin
client.suspending(::updatePersistentTaskState)(state)
}

@ObsoleteCoroutinesApi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change? Can we add the reason in the description please

@saikaranam-amazon saikaranam-amazon merged commit 0c01571 into opensearch-project:1.3 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants