Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version and snapshot param to maintain parity with default script #401

Merged
merged 1 commit into from
May 19, 2022
Merged

Add version and snapshot param to maintain parity with default script #401

merged 1 commit into from
May 19, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented May 19, 2022

Signed-off-by: Ankit Kala [email protected]

Description

Add version and snapshot param to maintain parity with default script

Issues Resolved

#400

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala requested a review from a team May 19, 2022 04:49
@ankitkala ankitkala enabled auto-merge (squash) May 19, 2022 04:51
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #401 (1a134fa) into main (f82c2ad) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #401      +/-   ##
============================================
- Coverage     74.94%   74.74%   -0.20%     
- Complexity      999     1000       +1     
============================================
  Files           141      141              
  Lines          4554     4554              
  Branches        504      504              
============================================
- Hits           3413     3404       -9     
- Misses          826      833       +7     
- Partials        315      317       +2     
Impacted Files Coverage Δ
...cation/action/changes/TransportGetChangesAction.kt 63.49% <0.00%> (-25.40%) ⬇️
...rch/replication/task/shard/ShardReplicationTask.kt 75.91% <0.00%> (+2.18%) ⬆️
...arch/replication/task/autofollow/AutoFollowTask.kt 75.67% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82c2ad...1a134fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants