Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move number_of_shards and number_of_replicas param out of index setting #392

Merged
merged 1 commit into from
May 6, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented May 6, 2022

Signed-off-by: Ankit Kala [email protected]

Description

Move the number_of_shards and number_of_replicas as we observed few test runs and these aren't getting honoured.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala requested a review from a team May 6, 2022 08:18
suranjay
suranjay previously approved these changes May 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #392 (5546a09) into main (e0dbe95) will decrease coverage by 1.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #392      +/-   ##
============================================
- Coverage     74.90%   73.32%   -1.59%     
+ Complexity      996      981      -15     
============================================
  Files           141      141              
  Lines          4554     4554              
  Branches        504      504              
============================================
- Hits           3411     3339      -72     
- Misses          828      903      +75     
+ Partials        315      312       -3     
Impacted Files Coverage Δ
...ch/replication/task/index/IndexReplicationState.kt 51.66% <0.00%> (-15.00%) ⬇️
...ication/action/setup/TransportSetupChecksAction.kt 59.52% <0.00%> (-14.29%) ⬇️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 80.00% <0.00%> (-11.67%) ⬇️
...tion/repository/RemoteClusterMultiChunkTransfer.kt 90.24% <0.00%> (-9.76%) ⬇️
.../replication/metadata/store/ReplicationMetadata.kt 62.96% <0.00%> (-8.65%) ⬇️
...earch/replication/metadata/UpdateIndexBlockTask.kt 74.19% <0.00%> (-6.46%) ⬇️
...ication/action/stop/StopIndexReplicationRequest.kt 50.00% <0.00%> (-5.00%) ⬇️
...ion/action/resume/ResumeIndexReplicationRequest.kt 50.00% <0.00%> (-5.00%) ⬇️
...tlin/org/opensearch/replication/util/Extensions.kt 65.47% <0.00%> (-4.77%) ⬇️
...n/index/ReplicateIndexClusterManagerNodeRequest.kt 50.00% <0.00%> (-4.17%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0dbe95...5546a09. Read the comment docs.

@ankitkala ankitkala merged commit 500a50a into opensearch-project:main May 6, 2022
@ankitkala ankitkala deleted the param branch April 5, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants