Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode the aws cdk versions #388

Merged
merged 1 commit into from
May 2, 2022
Merged

Hardcode the aws cdk versions #388

merged 1 commit into from
May 2, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented May 2, 2022

Signed-off-by: Ankit Kala [email protected]

Description

Changes done:

  • Hardcode the aws cdk versions due to incompatibility with newer versions. Keeping this in parity with OS Jenkins workflow(link).
This CDK CLI is not compatible with the CDK library used by your application. Please upgrade the CLI to the latest version.
(Cloud assembly schema version mismatch: Maximum schema version supported is 17.0.0, but found 18.0.0)
  • Added ndg-httpsclient, pyopenssl, pyasn1 to handle SSL error SSLError: EOF occurred in violation of protocol: (reference).
  • Added missing import.

Sample error:

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala requested a review from a team May 2, 2022 04:30
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #388 (318db82) into main (2c61666) will increase coverage by 1.49%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #388      +/-   ##
============================================
+ Coverage     73.05%   74.54%   +1.49%     
- Complexity      976      999      +23     
============================================
  Files           141      141              
  Lines          4554     4554              
  Branches        504      504              
============================================
+ Hits           3327     3395      +68     
+ Misses          913      842      -71     
- Partials        314      317       +3     
Impacted Files Coverage Δ
...cation/action/changes/TransportGetChangesAction.kt 63.49% <0.00%> (-20.64%) ⬇️
...ation/task/shard/ShardReplicationChangesTracker.kt 60.60% <0.00%> (-3.04%) ⬇️
...rch/replication/task/shard/ShardReplicationTask.kt 74.45% <0.00%> (+0.72%) ⬆️
.../action/status/TransportReplicationStatusAction.kt 97.82% <0.00%> (+1.08%) ⬆️
.../replication/action/index/ReplicateIndexRequest.kt 63.52% <0.00%> (+1.17%) ⬆️
...action/stop/TransportStopIndexReplicationAction.kt 69.33% <0.00%> (+1.33%) ⬆️
...arch/replication/task/autofollow/AutoFollowTask.kt 72.97% <0.00%> (+2.02%) ⬆️
...rch/replication/task/index/IndexReplicationTask.kt 70.99% <0.00%> (+2.78%) ⬆️
...org/opensearch/replication/util/SecurityContext.kt 73.52% <0.00%> (+2.94%) ⬆️
.../replication/repository/RemoteClusterRepository.kt 75.73% <0.00%> (+2.94%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c61666...318db82. Read the comment docs.

@ankitkala ankitkala enabled auto-merge (squash) May 2, 2022 06:06
@ankitkala ankitkala merged commit e0dbe95 into opensearch-project:main May 2, 2022
@ankitkala ankitkala deleted the version branch May 2, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants