Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf workflow: Added index codec and better exception handling #385

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Perf workflow: Added index codec and better exception handling #385

merged 2 commits into from
Apr 29, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Apr 29, 2022

Signed-off-by: Ankit Kala [email protected]

Description

Changes done:

  • Enforce index.codec:default for all workloads.
  • Fixed the exception handling and error logging.
  • Added retries to ES calls during test result validation.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala requested a review from a team April 29, 2022 10:07
Signed-off-by: Ankit Kala <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #385 (ddc3239) into main (6684bf7) will increase coverage by 0.39%.
The diff coverage is n/a.

❗ Current head ddc3239 differs from pull request most recent head c69b7cd. Consider uploading reports for the commit c69b7cd to get more accurate results

@@             Coverage Diff              @@
##               main     #385      +/-   ##
============================================
+ Coverage     74.48%   74.87%   +0.39%     
- Complexity      996      998       +2     
============================================
  Files           141      141              
  Lines          4554     4554              
  Branches        504      504              
============================================
+ Hits           3392     3410      +18     
+ Misses          845      830      -15     
+ Partials        317      314       -3     
Impacted Files Coverage Δ
...cation/action/changes/TransportGetChangesAction.kt 84.12% <0.00%> (-6.35%) ⬇️
...arch/replication/metadata/UpdateMetadataRequest.kt 95.45% <0.00%> (-4.55%) ⬇️
...ation/task/shard/ShardReplicationChangesTracker.kt 60.60% <0.00%> (-3.04%) ⬇️
...rch/replication/task/shard/ShardReplicationTask.kt 73.72% <0.00%> (-0.73%) ⬇️
...rch/replication/task/index/IndexReplicationTask.kt 71.22% <0.00%> (+0.23%) ⬆️
...earch/replication/metadata/UpdateIndexBlockTask.kt 77.41% <0.00%> (+3.22%) ⬆️
...rch/replication/action/status/ShardInfoResponse.kt 91.59% <0.00%> (+19.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6684bf7...c69b7cd. Read the comment docs.

Copy link
Member

@saikaranam-amazon saikaranam-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - If not done already, Can we open issue on our end to assert on other metrics as well?

@ankitkala ankitkala merged commit 2c61666 into opensearch-project:main Apr 29, 2022
@ankitkala ankitkala deleted the codec-pr branch April 29, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants