Adding validation on index settings #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkala
previously approved these changes
Jul 1, 2021
| @@ -78,6 +79,11 @@ class TransportUpdateIndexReplicationAction @Inject constructor(transportService | |||
| } | |||
|
|
|||
| private fun validateUpdateReplicationRequest(request: UpdateIndexReplicationRequest) { | |||
| IndexScopedSettings.DEFAULT_SCOPED_SETTINGS.validate( | |||
There was a problem hiding this comment.
Can we check this validation at the request level?
There was a problem hiding this comment.
I plan to use SettingsModule instead of IndexScopedSettings in next PR . Hence this needs to be even moved down further where that module is available.
saikaranam-amazon
previously approved these changes
Jul 8, 2021
ankitkala
approved these changes
Jul 8, 2021
saikaranam-amazon
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #35
Description
Validates index settings value passed
Issues Resolved
#35
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.