Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed master to clusterManager (#319) #355

Conversation

naveenpajjuri
Copy link
Contributor

@naveenpajjuri naveenpajjuri commented Apr 6, 2022

Signed-off-by: Naveen Pajjuri [email protected]

Description

Replaced the word master with cluster manager where ever possible.
We still have external packages like OS, etc where we have few paths with master nomenclature which can only be fixed later.

Issues Resolved

#319

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveenpajjuri naveenpajjuri requested a review from a team April 6, 2022 05:31
@codecov-commenter
Copy link

Codecov Report

Merging #355 (26a92da) into main (d5318e6) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 26a92da differs from pull request most recent head 27960e9. Consider uploading reports for the commit 27960e9 to get more accurate results

@@            Coverage Diff            @@
##               main     #355   +/-   ##
=========================================
  Coverage     10.90%   10.90%           
  Complexity      111      111           
=========================================
  Files           141      141           
  Lines          4559     4559           
  Branches        506      506           
=========================================
  Hits            497      497           
  Misses         3991     3991           
  Partials         71       71           
Impacted Files Coverage Δ
...in/org/opensearch/replication/ReplicationPlugin.kt 23.77% <0.00%> (ø)
...n/autofollow/AutoFollowClusterManagerNodeAction.kt 0.00% <0.00%> (ø)
.../autofollow/AutoFollowClusterManagerNodeRequest.kt 0.00% <ø> (ø)
...low/TransportAutoFollowClusterManagerNodeAction.kt 0.00% <0.00%> (ø)
...tofollow/TransportUpdateAutoFollowPatternAction.kt 0.00% <0.00%> (ø)
...on/index/ReplicateIndexClusterManagerNodeAction.kt 0.00% <0.00%> (ø)
...tion/action/index/TransportReplicateIndexAction.kt 0.00% <0.00%> (ø)
...TransportReplicateIndexClusterManagerNodeAction.kt 0.00% <0.00%> (ø)
...tion/action/replay/TransportReplayChangesAction.kt 0.00% <ø> (ø)
...rch/replication/task/index/IndexReplicationTask.kt 25.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5318e6...27960e9. Read the comment docs.

ankitkala
ankitkala previously approved these changes Apr 6, 2022
@naveenpajjuri naveenpajjuri merged commit d51e43c into opensearch-project:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants