Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterised tests with all java versions. #329

Merged

Conversation

naveenpajjuri
Copy link
Contributor

@naveenpajjuri naveenpajjuri commented Mar 8, 2022

Description

changes in CI matrix in workflow to run tests on JDK 8,11 and 14 versions

Issues Resolved

Issue : #254

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveenpajjuri naveenpajjuri requested a review from a team March 8, 2022 11:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #329 (af6ce63) into main (67afce7) will decrease coverage by 4.08%.
The diff coverage is n/a.

❗ Current head af6ce63 differs from pull request most recent head 3892992. Consider uploading reports for the commit 3892992 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #329      +/-   ##
============================================
- Coverage     73.52%   69.43%   -4.09%     
+ Complexity      913      856      -57     
============================================
  Files           139      139              
  Lines          4427     4427              
  Branches        521      521              
============================================
- Hits           3255     3074     -181     
- Misses          850     1029     +179     
- Partials        322      324       +2     
Impacted Files Coverage Δ
...earch/replication/action/stats/NodeStatsRequest.kt 33.33% <0.00%> (-66.67%) ⬇️
...eplication/action/stats/LeaderNodeStatsResponse.kt 42.85% <0.00%> (-42.86%) ⬇️
.../replication/action/replay/ReplayChangesRequest.kt 52.38% <0.00%> (-38.10%) ⬇️
...arch/replication/metadata/UpdateMetadataRequest.kt 38.09% <0.00%> (-38.10%) ⬇️
...replication/action/index/ReplicateIndexResponse.kt 33.33% <0.00%> (-33.34%) ⬇️
...tion/action/index/block/UpdateIndexBlockRequest.kt 31.57% <0.00%> (-31.58%) ⬇️
...replication/action/stats/AutoFollowStatsRequest.kt 71.42% <0.00%> (-28.58%) ⬇️
...opensearch/replication/seqno/RemoteClusterStats.kt 73.01% <0.00%> (-26.99%) ⬇️
.../replication/action/index/ReplicateIndexRequest.kt 43.37% <0.00%> (-25.31%) ⬇️
...on/action/index/ReplicateIndexMasterNodeRequest.kt 29.16% <0.00%> (-25.01%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67afce7...3892992. Read the comment docs.

@naveenpajjuri naveenpajjuri force-pushed the Workflow_multiple_jdk branch from 3892992 to 1f17d48 Compare March 8, 2022 12:46
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitkala ankitkala merged commit 4306221 into opensearch-project:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants