Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced status API validations to check for index name #317

Merged

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Mar 2, 2022

Signed-off-by: Sai Kumar [email protected]

Description

Enhanced status API validations to check for index name

GET _plugins/_replication//_status?pretty" 

{
  "error" : {
    "root_cause" : [
      {
        "type" : "action_request_validation_exception",
        "reason" : "Validation Failed: 1: Index name should be specified to obtain replication status;"
      }
    ],
    "type" : "action_request_validation_exception",
    "reason" : "Validation Failed: 1: Index name should be specified to obtain replication status;"
  },
  "status" : 400
}

Issues Resolved

#314

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #317 (a6e4193) into main (f309eaa) will decrease coverage by 1.40%.
The diff coverage is 100.00%.

❗ Current head a6e4193 differs from pull request most recent head 275e380. Consider uploading reports for the commit 275e380 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #317      +/-   ##
============================================
- Coverage     72.94%   71.53%   -1.41%     
+ Complexity      905      897       -8     
============================================
  Files           139      139              
  Lines          4424     4427       +3     
  Branches        519      521       +2     
============================================
- Hits           3227     3167      -60     
- Misses          870      934      +64     
+ Partials        327      326       -1     
Impacted Files Coverage Δ
...arch/replication/action/status/ShardInfoRequest.kt 78.94% <100.00%> (+3.94%) ⬆️
...earch/replication/rest/ReplicationStatusHandler.kt 100.00% <100.00%> (ø)
...ication/action/setup/TransportSetupChecksAction.kt 58.62% <0.00%> (-13.80%) ⬇️
...ch/replication/task/index/IndexReplicationState.kt 48.33% <0.00%> (-13.34%) ⬇️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 80.00% <0.00%> (-11.67%) ⬇️
...tion/repository/RemoteClusterMultiChunkTransfer.kt 70.73% <0.00%> (-9.76%) ⬇️
...ication/action/stats/TransportLeaderStatsAction.kt 70.83% <0.00%> (-8.34%) ⬇️
.../replication/metadata/store/ReplicationMetadata.kt 75.32% <0.00%> (-6.50%) ⬇️
...action/stop/TransportStopIndexReplicationAction.kt 70.00% <0.00%> (-5.72%) ⬇️
...ication/action/stop/StopIndexReplicationRequest.kt 57.89% <0.00%> (-5.27%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f309eaa...275e380. Read the comment docs.

@saikaranam-amazon saikaranam-amazon marked this pull request as draft March 3, 2022 05:48
@saikaranam-amazon saikaranam-amazon removed the request for review from a team March 3, 2022 05:48
@saikaranam-amazon saikaranam-amazon marked this pull request as ready for review March 8, 2022 06:08
@saikaranam-amazon
Copy link
Member Author

Integ tests fixed in: #322

Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitkala ankitkala merged commit 67afce7 into opensearch-project:main Mar 8, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 8, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 8, 2022
saikaranam-amazon added a commit that referenced this pull request Jun 3, 2022
saikaranam-amazon added a commit that referenced this pull request Jun 3, 2022
saikaranam-amazon added a commit that referenced this pull request Aug 26, 2022
(cherry picked from commit 67afce7)
Signed-off-by: Sai Kumar <[email protected]>

Co-authored-by: Sai <[email protected]>
saikaranam-amazon added a commit that referenced this pull request Aug 26, 2022
saikaranam-amazon added a commit that referenced this pull request Dec 27, 2022
(cherry picked from commit 67afce7)
Signed-off-by: Sai Kumar <[email protected]>

Co-authored-by: Sai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants