Changed names for assume roles to remote and local from leader and follower #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-ggk
reviewed
Jun 30, 2021
src/main/kotlin/com/amazon/elasticsearch/replication/action/index/ReplicateIndexRequest.kt
Outdated
Show resolved
Hide resolved
Comment on lines
130
to
131
| log.debug("Prefer node is ${shardRouting.currentNodeId()}") | ||
| return "_prefer_nodes:${shardRouting.currentNodeId()}" |
There was a problem hiding this comment.
- Should we be using
_only_nodesinstead or probably have a param which will do that? (Something like DDB consistent reads where the callers can explicitly opt for getting consistent state where required and getting from replica where slight staleness is ok) - Can we include the index or something as well in the log? (Basically trying to see if we can connect the log statement to appropriate index if that isn't part of log context)
There was a problem hiding this comment.
Added the index info to the log. we can discuss regarding the _only_nodes as param
saikaranam-amazon
force-pushed
the
fgac-roles-renaming
branch
from
f8562cf to
b95b8ce
Compare
krishna-ggk
previously approved these changes
Jun 30, 2021
Comment on lines
-55
to
57
| const val LEADER_FGAC_ROLE = "leader_fgac_role" | ||
| const val FOLLOWER_FGAC_ROLE = "follower_fgac_role" | ||
| const val LEADER_FGAC_ROLE = "remote_cluster_role" | ||
| const val FOLLOWER_FGAC_ROLE = "local_cluster_role" | ||
| private val INDEX_REQ_PARSER = ObjectParser<ReplicateIndexRequest, Void>("FollowIndexRequestParser") { ReplicateIndexRequest() } |
There was a problem hiding this comment.
Nit - we could have renamed var names as well.
gbbafna
reviewed
Jun 30, 2021
src/main/kotlin/com/amazon/elasticsearch/replication/metadata/store/ReplicationMetadataStore.kt
Outdated
Show resolved
Hide resolved
naveenpajjuri
previously approved these changes
Jun 30, 2021
| @@ -66,7 +66,7 @@ fun <Req, Resp> Client.suspending(fn: (Req, ActionListener<Resp>) -> Unit, | |||
| } | |||
| } | |||
|
|
|||
| fun <Req, Resp> Client.suspending(replicationMetadata: ReplicationMetadata, | |||
| suspend fun <Req, Resp> Client.suspending(replicationMetadata: ReplicationMetadata, | |||
There was a problem hiding this comment.
Just for my understanding, Why are we making these suspend?
because some non suspend methods might be calling them right?
gbbafna
previously approved these changes
Jun 30, 2021
saikaranam-amazon
dismissed stale reviews from gbbafna, naveenpajjuri, and krishna-ggk
via
6d62e81
saikaranam-amazon
force-pushed
the
fgac-roles-renaming
branch
from
b95b8ce to
6d62e81
Compare
…llower Added preference to fetch the metdata from the primary shard Additional logging for the metadata store
saikaranam-amazon
force-pushed
the
fgac-roles-renaming
branch
from
6d62e81 to
6c3698e
Compare
krishna-ggk
approved these changes
Jun 30, 2021
gbbafna
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.