Add Replication plugin BWC tests #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Kala <[email protected]>
saikaranam-amazon
approved these changes
Nov 23, 2021
gbbafna
reviewed
Nov 23, 2021
Comment on lines
+576
to
+599
| useCluster testClusters.bwcLeader0 | ||
| useCluster testClusters.bwcFollower0 | ||
| doFirst { | ||
| testClusters.bwcLeader0.upgradeNodeAndPluginToNextVersion(replPluginProvider) | ||
| testClusters.bwcFollower0.upgradeNodeAndPluginToNextVersion(replPluginProvider) | ||
| getClusters().forEach { cluster -> | ||
| String alltransportSocketURI = cluster.nodes.stream().flatMap { node -> | ||
| node.getAllTransportPortURI().stream() | ||
| }.collect(Collectors.joining(",")) | ||
| String allHttpSocketURI = cluster.nodes.stream().flatMap { node -> | ||
| node.getAllHttpSocketURI().stream() | ||
| }.collect(Collectors.joining(",")) | ||
|
|
||
| systemProperty "tests.cluster.${cluster.name}.http_hosts", "${-> allHttpSocketURI}" | ||
| systemProperty "tests.cluster.${cluster.name}.transport_hosts", "${-> alltransportSocketURI}" | ||
| systemProperty "tests.cluster.${cluster.name}.security_enabled", "${-> securityEnabled.toString()}" | ||
| configureCluster(cluster, securityEnabled) | ||
| } | ||
| } | ||
| nonInputProperties.systemProperty('tests.bwcTask', "twoThirdsUpgradedClusterTask") | ||
| nonInputProperties.systemProperty('tests.cluster_suffix', "0") | ||
| filter { | ||
| setIncludePatterns("org.opensearch.replication.bwc.BackwardsCompatibilityIT") | ||
| } |
There was a problem hiding this comment.
can we put this in a common function so that duplication with mixedClusterTask and rollingUpgradeClusterTask can be reduced ?
There was a problem hiding this comment.
I had tried that earlier but there were some issue with setting system properties and thus we had to duplicate the logic.
gbbafna
approved these changes
Nov 23, 2021
|
This added -SNAPSHOT binaries to the tree, which is probably not what we wanted, see #274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankit Kala [email protected]
Description
Adds Backward compatibility tests for replication plugin
Re-raised(old PR) as we recently got branch protection rule due to which i can't push more changes(without PR) in any private branch in main repo.
Task flow:
bwcLeader0+bwcFollower0:oldVersionClusterTask0-->mixedClusterTaskoldVersionClusterTask0-->mixedClusterTask-->twoThirdsUpgradedClusterTask-->rollingUpgradeClusterTaskbwcLeader1+bwcFollower1:oldVersionClusterTask1-->fullRestartClusterTaskHow to execute
./gradlew bwcTestSuite./gradlew mixedClusterTask./gradlew rollingUpgradeClusterTask./gradlew fullRestartClusterTaskIssues Resolved
#116
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.