-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Changes to ensure replication tasks are not failing prematurely #231
Merged
saikaranam-amazon
merged 1 commit into
opensearch-project:main
from
saikaranam-amazon:main-index-task-premature
Nov 5, 2021
Merged
BugFix: Changes to ensure replication tasks are not failing prematurely #231
saikaranam-amazon
merged 1 commit into
opensearch-project:main
from
saikaranam-amazon:main-index-task-premature
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikaranam-amazon
force-pushed
the
main-index-task-premature
branch
2 times, most recently
from
October 30, 2021 07:09
3a17f01
to
aea6890
Compare
ankitkala
reviewed
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 2 minor comments.
src/main/kotlin/org/opensearch/replication/task/autofollow/AutoFollowTask.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt
Show resolved
Hide resolved
gbbafna
reviewed
Nov 2, 2021
src/main/kotlin/org/opensearch/replication/metadata/store/ReplicationMetadataStore.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/replication/metadata/store/ReplicationMetadataStore.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/replication/metadata/store/ReplicationMetadataStore.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt
Show resolved
Hide resolved
saikaranam-amazon
force-pushed
the
main-index-task-premature
branch
from
November 3, 2021 12:07
aea6890
to
cbead23
Compare
gbbafna
reviewed
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 1 nit comment.
src/main/kotlin/org/opensearch/replication/metadata/store/ReplicationMetadataStore.kt
Outdated
Show resolved
Hide resolved
ankitkala
previously approved these changes
Nov 4, 2021
saikaranam-amazon
force-pushed
the
main-index-task-premature
branch
from
November 4, 2021 14:20
cbead23
to
0177354
Compare
ankitkala
previously approved these changes
Nov 5, 2021
Signed-off-by: Sai Kumar <[email protected]>
saikaranam-amazon
force-pushed
the
main-index-task-premature
branch
from
November 5, 2021 06:56
0177354
to
b75b6a3
Compare
naveenpajjuri
approved these changes
Nov 5, 2021
ankitkala
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BugFix: Changes to ensure replication tasks are not failing prematurely
Issues Resolved
#222
Tesing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.