Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Changes to ensure replication tasks are not failing prematurely #231

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Oct 29, 2021

Description

BugFix: Changes to ensure replication tasks are not failing prematurely

Issues Resolved

#222

Tesing

  • Tested on live clusters with on-going replication
  • Local tests pass

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saikaranam-amazon saikaranam-amazon force-pushed the main-index-task-premature branch 2 times, most recently from 3a17f01 to aea6890 Compare October 30, 2021 07:09
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 2 minor comments.

@saikaranam-amazon saikaranam-amazon force-pushed the main-index-task-premature branch from aea6890 to cbead23 Compare November 3, 2021 12:07
Copy link
Collaborator

@gbbafna gbbafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 nit comment.

ankitkala
ankitkala previously approved these changes Nov 4, 2021
ankitkala
ankitkala previously approved these changes Nov 5, 2021
@saikaranam-amazon saikaranam-amazon merged commit 4389c42 into opensearch-project:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants