Derive security context information when security plugin fails to populate user info #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulate user info Signed-off-by: Sai Kumar <[email protected]>
soosinha
approved these changes
Oct 19, 2021
krishna-ggk
reviewed
Oct 22, 2021
Comment on lines
+59
to
65
| if(userInfo == null && userObj != null) { | ||
| // Case: When admin certs are used, security plugin skips populating the user info in thread context. | ||
| // If userObj(obj) is present and userInfo(String) is not populated, assuming admin role for the user and | ||
| // only passed role(use_roles) in the request is stored after checks (as admin should have access to all roles) | ||
| userInfo = "adminDN|" | ||
| } | ||
| return User.parse(userInfo) |
There was a problem hiding this comment.
Is this safe? Should anything be parsed from userObj?
There was a problem hiding this comment.
Yes, and we don't have direct access to userObj.
This is to make sure, we have place holder for user and doesn't assume that security context is not passed. All the checks are performed in the security plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Derive security context information when security plugin fails to populate user info
Issues Resolved
#203
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.