Gracefully fail replication on bootstrap failure. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -178,9 +181,11 @@ class TransportStopIndexReplicationAction @Inject constructor(transportService: | |||
| ?: | |||
| throw IllegalArgumentException("No replication in progress for index:${request.indexName}") | |||
| val replicationOverallState = replicationStateParams[REPLICATION_LAST_KNOWN_OVERALL_STATE] | |||
| if (replicationOverallState == ReplicationOverallState.RUNNING.name) | |||
| if (replicationOverallState == ReplicationOverallState.PAUSED.name) | |||
There was a problem hiding this comment.
Based on previous logic, this should return true in "Pause" state?
There was a problem hiding this comment.
Yeah, just realized and updated.
While at it, also support Stopping FAILED index (mainly cleanup) and handle FAILED state in other actions. Signed-off-by: Gopala Krishna Ambareesh <[email protected]>
saikaranam-amazon
approved these changes
Sep 17, 2021
gbbafna
approved these changes
Sep 17, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully fail replication on bootstrap failure.
While at it, also support Stopping FAILED index (mainly cleanup) and
handle FAILED state in other actions.
Signed-off-by: Gopala Krishna Ambareesh [email protected]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.