Doing stop after shard tasks are up . #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna-ggk
reviewed
Sep 16, 2021
Comment on lines
87
to
88
| followerClient.waitForReplicationStart(leaderIndexName, waitForShardTask) | ||
| followerClient.waitForReplicationStart(leaderIndexNameNew, waitForShardTask) |
There was a problem hiding this comment.
These are probably better added in the try block. That way we also clearly ensure replication was started as well.
There was a problem hiding this comment.
We can probably keep it after leaderIndexNameNew is created on the leader side.
Same feedback for other tests as well.
Signed-off-by: Gaurav Bafna <[email protected]>
ankitkala
approved these changes
Sep 16, 2021
krishna-ggk
approved these changes
Sep 16, 2021
gbbafna
added a commit
to gbbafna/cross-cluster-replication
that referenced
this pull request
Sep 17, 2021
Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna
added a commit
that referenced
this pull request
Sep 17, 2021
Signed-off-by: Gaurav Bafna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Bafna [email protected]
Description
Fixing integ tests which are broken due to #152
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.