Configure the threadpool for leader cluster #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkala
assigned krishna-ggk, naveenpajjuri, amazon-auto, saikaranam-amazon, tbhanu-amzn and soosinha and unassigned amazon-auto
tbhanu-amzn
reviewed
Jun 8, 2021
src/main/kotlin/com/amazon/elasticsearch/replication/ReplicationPlugin.kt
Outdated
Show resolved
Hide resolved
saikaranam-amazon
previously approved these changes
Jun 9, 2021
ankitkala
force-pushed
the
leader_threadpool
branch
from
74921d5 to
0540aa0
Compare
saikaranam-amazon
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configured a separate thread pool for leader.
I've kept the thread pool configuration in parity with search which is what we were using earlier. I've also added settings to keep it configurable. Search uses
AutoQueueAdjustingExecutorBuilderwhich has fixed number of worker threads but can dynamically change queue size.Since
AutoQueueAdjustingExecutorBuildercan't be accessed by the plugins so i've usedFixedExecutorBuilderwhich has a fixed number of worker threads and a fixed size queue.References:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.