Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SystemIndex #1290

Merged

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Dec 6, 2023

Description

Implement getSystemIndexDescriptors to support SystemIndex

Issues Resolved

#1100

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: monusingh-1 <[email protected]>
@monusingh-1 monusingh-1 marked this pull request as ready for review December 6, 2023 11:11
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12ebd7e) 74.81% compared to head (dcc5d9b) 74.75%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1290      +/-   ##
============================================
- Coverage     74.81%   74.75%   -0.06%     
+ Complexity     1030     1025       -5     
============================================
  Files           141      141              
  Lines          4776     4777       +1     
  Branches        525      525              
============================================
- Hits           3573     3571       -2     
+ Misses          862      861       -1     
- Partials        341      345       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monusingh-1 monusingh-1 merged commit 577fd62 into opensearch-project:main Dec 6, 2023
14 of 15 checks passed
@monusingh-1 monusingh-1 deleted the add_systemindex_support branch December 6, 2023 13:34
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 6, 2023
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 577fd62)
monusingh-1 added a commit that referenced this pull request Dec 7, 2023
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 577fd62)

Co-authored-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants