Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure #1281

Merged

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Oct 27, 2023

Description

upstream change opensearch-project/OpenSearch@e691df0
Fix

e: file:///Users/msnghgw/main/ccr-dev/src/main/kotlin/org/opensearch/replication/action/replay/TransportReplayChangesAction.kt:75:69 No value passed for parameter 'p14'

> Task :compileKotlin FAILED

FAILURE: Build failed with an exception.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: monusingh-1 <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1281 (a394e45) into main (e1d2596) will decrease coverage by 28.94%.
The diff coverage is 100.00%.

❗ Current head a394e45 differs from pull request most recent head 5793269. Consider uploading reports for the commit 5793269 to get more accurate results

@@              Coverage Diff              @@
##               main    #1281       +/-   ##
=============================================
- Coverage     75.02%   46.08%   -28.94%     
+ Complexity     1024      625      -399     
=============================================
  Files           141      141               
  Lines          4776     4776               
  Branches        525      525               
=============================================
- Hits           3583     2201     -1382     
- Misses          852     2304     +1452     
+ Partials        341      271       -70     
Files Coverage Δ
...tion/action/replay/TransportReplayChangesAction.kt 68.96% <100.00%> (-13.80%) ⬇️

... and 81 files with indirect coverage changes

@monusingh-1 monusingh-1 marked this pull request as ready for review October 27, 2023 08:12
@monusingh-1 monusingh-1 enabled auto-merge (squash) October 27, 2023 08:14
@monusingh-1 monusingh-1 merged commit 12ebd7e into opensearch-project:main Oct 27, 2023
15 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 12ebd7e)
@monusingh-1 monusingh-1 deleted the fix_trasport_replayaction branch October 27, 2023 08:44
monusingh-1 added a commit to monusingh-1/ccr-dev that referenced this pull request Dec 12, 2023
monusingh-1 added a commit to monusingh-1/ccr-dev that referenced this pull request Dec 12, 2023
Fix build failure (opensearch-project#1281)

Signed-off-by: monusingh-1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants