Remove numNodes parameter in security tests (#991) #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the integ tests like those for wait_for_active_shards need atleast 2 nodes in the cluster to run successfully. Removing the numNodes=1 parameter so that by default 2 node cluster is created Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit c19dcba)
monusingh-1
approved these changes
Sep 11, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1135 +/- ##
============================================
- Coverage 76.57% 76.46% -0.11%
+ Complexity 1046 1042 -4
============================================
Files 141 141
Lines 4764 4764
Branches 521 521
============================================
- Hits 3648 3643 -5
- Misses 776 780 +4
- Partials 340 341 +1 |
ankitkala
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #991
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.