Adding UTs for IndexReplicationTask #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things added in main code path :
|
krishna-ggk
previously approved these changes
Aug 18, 2021
src/test/kotlin/org/opensearch/replication/task/index/IndexReplicationTaskTests.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+152
to
+136
| // Delay to let task execute | ||
| delay(1000) |
There was a problem hiding this comment.
Nit - yield is a better way to yield back instead of delay.
|
|
||
| } | ||
|
|
||
| open class NoOpClient(testName :String) : NoOpNodeClient(testName) { |
There was a problem hiding this comment.
Seems like this could be extracted out and can also be helpful for other tests.
There was a problem hiding this comment.
I have extracted out from IndexReplicationTaskTests , but kept it in the same package as it needs all variables like follower index et all and is IndexReplicationTask specific as of now.
krishna-ggk
approved these changes
Aug 20, 2021
ankitkala
approved these changes
Aug 24, 2021
| var taskManager = Mockito.mock(TaskManager::class.java) | ||
| replicationTask.setPersistent(taskManager) | ||
| var rc = ReplicationContext(followerIndex) | ||
| var rm = ReplicationMetadata(connectionName, ReplicationStoreMetadataType.INDEX.name, ReplicationOverallState.RUNNING.name, "reason", rc, rc, Settings.EMPTY) |
There was a problem hiding this comment.
Minor: We can probably move the logic to create ReplicationMetadata, ClusterState, etc objects to a helper utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding UTs for IndexReplicationTask
Issues Resolved
#108
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.