Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mapping update for the replication store system index #105

Merged

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Aug 18, 2021

Description

Support for mapping update for the replication store system index

Issues Resolved

N/A

Testing

./gradlew clean release 

Manually tested on cluster
Before

curl "localhost:9200/.replication-metadata-store/_mapping?pretty"
{
  ".replication-metadata-store" : {
    "mappings" : {
      "dynamic" : "strict",
      "_meta" : {
        "schema_version" : 1
      },

After

curl "localhost:9200/.replication-metadata-store/_mapping?pretty"
{
  ".replication-metadata-store" : {
    "mappings" : {
      "dynamic" : "strict",
      "_meta" : {
        "schema_version" : 3
      },
      "properties" : {
        "connection_name" : {
          

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@krishna-ggk krishna-ggk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to include tests to confirm schema version can be safely updated. Can you assess if it is introduce able now or requires significant plumbing work?

@saikaranam-amazon
Copy link
Member Author

It would be great to include tests to confirm schema version can be safely updated. Can you assess if it is introduce able now or requires significant plumbing work?

Added issue to track UTs: #113

Copy link
Contributor

@naveenpajjuri naveenpajjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikaranam-amazon saikaranam-amazon merged commit de677c6 into opensearch-project:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants