Monitor model changed to add an optional fanoutEnabled field #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
lezzago,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
sbcd90,
AWSHurneyt,
engechas and
jowg-amazon
as code owners
Signed-off-by: Riya Saxena <[email protected]>
5 tasks
eirsep
previously approved these changes
Dec 17, 2024
AWSHurneyt
reviewed
Dec 17, 2024
src/main/kotlin/org/opensearch/commons/alerting/model/Monitor.kt
Outdated
Show resolved
Hide resolved
AWSHurneyt
reviewed
Dec 17, 2024
src/main/kotlin/org/opensearch/commons/alerting/model/Monitor.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
AWSHurneyt
approved these changes
Dec 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit cb9d38b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
UTs will add as a follow up |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit cb9d38b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit cb9d38b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit cb9d38b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * Monitor model changed to add an optional fanoutEnabled field Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> * move fanoutEnabled to docLevel input Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit cb9d38b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Dec 17, 2024
…763) * Monitor model changed to add an optional fanoutEnabled field * Monitor model changed to add an optional fanoutEnabled field * move fanoutEnabled to docLevel input * move fanoutEnabled to docLevel input * move fanoutEnabled to docLevel input --------- (cherry picked from commit cb9d38b) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90
pushed a commit
that referenced
this pull request
Dec 18, 2024
…762) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90
pushed a commit
that referenced
this pull request
Dec 18, 2024
…765) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detectors configured with aggregation sigma rules should ideally generate only one alert in one execution when a set of documents match the rule’s condition. But currently there are duplicate alerts being generated when aggregate sigma rules are matched.
This PR adds a field in monitor
fanoutEnabled(optional field), default value of this flag will be true. When detector is created/updated, the value of this field will be set to false in case chained findings doc level monitor, this will ensure that fanout approach will be disabled when executing doc level monitorRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.