add ignore_findings_and_alerts field to monitors #756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <[email protected]>
sbcd90
requested review from
lezzago,
bowenlan-amzn,
rishabhmaurya,
getsaurabh02,
eirsep,
AWSHurneyt,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
eirsep
reviewed
Nov 20, 2024
| @@ -112,6 +113,7 @@ data class Monitor( | |||
| DataSources() | |||
| }, | |||
| deleteQueryIndexInEveryRun = sin.readOptionalBoolean(), | |||
| ignoreFindingsAndAlerts = sin.readOptionalBoolean(), | |||
There was a problem hiding this comment.
NIT: should we rename to shouldPersistFindingsAndAlerts?
There was a problem hiding this comment.
fixed it. default is already False.
5 tasks
|
closing this in favor of #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add ignore_findings_and_alerts field to monitors
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.