-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auditDelegateMonitorAlerts flag #476
Conversation
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
============================================
+ Coverage 74.37% 74.41% +0.04%
- Complexity 859 861 +2
============================================
Files 129 129
Lines 5573 5586 +13
Branches 683 684 +1
============================================
+ Hits 4145 4157 +12
Misses 1125 1125
- Partials 303 304 +1
|
@@ -20,6 +20,7 @@ class GetWorkflowResponseTests { | |||
val sin = StreamInput.wrap(out.bytes().toBytesRef().bytes) | |||
val newRes = GetWorkflowResponse(sin) | |||
Assertions.assertEquals("id", newRes.id) | |||
Assertions.assertFalse(newRes.workflow!!.auditDelegateMonitorAlerts!!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need another test where it checks if this is true when auditDelegateMonitorAlerts
is not set.
Signed-off-by: Surya Sashank Nistala <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-476-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2e9ddc9aabe433901f0893c67d24fc8e3755992
# Push it to GitHub
git push --set-upstream origin backport/backport-476-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* add auditDelegateMonitorAlerts flag Signed-off-by: Surya Sashank Nistala <[email protected]> * add audit state check in error alert validation Signed-off-by: Surya Sashank Nistala <[email protected]> * add test to verify workflow with auditDelegateMonitor flag null Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
* add auditDelegateMonitorAlerts flag * add audit state check in error alert validation * add test to verify workflow with auditDelegateMonitor flag null --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
* add auditDelegateMonitorAlerts flag * add audit state check in error alert validation * add test to verify workflow with auditDelegateMonitor flag null --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 90bea0c)
* add auditDelegateMonitorAlerts flag * add audit state check in error alert validation * add test to verify workflow with auditDelegateMonitor flag null --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 90bea0c) Co-authored-by: Surya Sashank Nistala <[email protected]>
…rch-project#477) * add auditDelegateMonitorAlerts flag * add audit state check in error alert validation * add test to verify workflow with auditDelegateMonitor flag null --------- Signed-off-by: Surya Sashank Nistala <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.