-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a super admin client builder w/ hosts params #322
Merged
bowenlan-amzn
merged 1 commit into
opensearch-project:main
from
bowenlan-amzn:superadminclient
Nov 19, 2022
Merged
Add a super admin client builder w/ hosts params #322
bowenlan-amzn
merged 1 commit into
opensearch-project:main
from
bowenlan-amzn:superadminclient
Nov 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
============================================
- Coverage 73.42% 73.29% -0.13%
+ Complexity 698 696 -2
============================================
Files 110 110
Lines 4587 4595 +8
Branches 606 606
============================================
Hits 3368 3368
- Misses 968 976 +8
Partials 251 251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lezzago
approved these changes
Nov 18, 2022
praveensameneni
approved these changes
Nov 19, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 19, 2022
Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 050c95d)
bowenlan-amzn
added a commit
that referenced
this pull request
Nov 19, 2022
Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 050c95d) Co-authored-by: bowenlan-amzn <[email protected]>
4 tasks
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
) (opensearch-project#323) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 050c95d) Co-authored-by: bowenlan-amzn <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
) (opensearch-project#323) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit 050c95d) Co-authored-by: bowenlan-amzn <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bowenlan-amzn [email protected]
Description
Duplicate the super admin client constructor with hosts params. Currently we hardcode the host to be localhost:9200 in super admin client.
Issues Resolved
opensearch-project/index-management#612
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.