Added legacy support for SNS messages. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezzago
previously approved these changes
Sep 27, 2022
qreshi
previously approved these changes
Oct 6, 2022
|
Let's merge this against We called out here sometime back that in 3.0 we'll be removing legacy support for Destinations and migration but we haven't made those changes for |
AWSHurneyt
dismissed stale reviews from qreshi and lezzago
The base branch was changed.
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
force-pushed
the
2.3_legacy_sns
branch
from
69369dc to
7936ff4
Compare
qreshi
approved these changes
Oct 6, 2022
Done. |
lezzago
approved these changes
Oct 6, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
* Added legacy support for SNS messages. Signed-off-by: AWSHurneyt <[email protected]> * Added license header to new classes. Signed-off-by: AWSHurneyt <[email protected]> * Fixed style errors. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 9c2621e)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
* Added legacy support for SNS messages. Signed-off-by: AWSHurneyt <[email protected]> * Added license header to new classes. Signed-off-by: AWSHurneyt <[email protected]> * Fixed style errors. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 9c2621e)
lezzago
pushed a commit
that referenced
this pull request
Oct 7, 2022
* Added legacy support for SNS messages. Signed-off-by: AWSHurneyt <[email protected]> * Added license header to new classes. Signed-off-by: AWSHurneyt <[email protected]> * Fixed style errors. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 9c2621e) Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
that referenced
this pull request
Oct 10, 2022
* Added legacy support for SNS messages. Signed-off-by: AWSHurneyt <[email protected]> * Added license header to new classes. Signed-off-by: AWSHurneyt <[email protected]> * Fixed style errors. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 9c2621e) Co-authored-by: AWSHurneyt <[email protected]>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
…search-project#269) * Added legacy support for SNS messages. Signed-off-by: AWSHurneyt <[email protected]> * Added license header to new classes. Signed-off-by: AWSHurneyt <[email protected]> * Fixed style errors. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 9c2621e) Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…search-project#269) * Added legacy support for SNS messages. Signed-off-by: AWSHurneyt <[email protected]> * Added license header to new classes. Signed-off-by: AWSHurneyt <[email protected]> * Fixed style errors. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 9c2621e) Co-authored-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AWSHurneyt [email protected]
Description
Added legacy support for SNS messages. These changes will need to be back ported back to version 2.3.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.