Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allowedConfigFeatureList from GetPluginFeaturesResponse for Notifications #144

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Mar 24, 2022

Signed-off-by: Mohammad Qureshi [email protected]

Description

Since allowed_config_features is no longer being used this PR removes it from the Notifications Get Plugin Features API response

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please link to the removal/deprecation of allowed_config_features PR/issue/anything?

@qreshi
Copy link
Contributor Author

qreshi commented Mar 24, 2022

Could you please link to the removal/deprecation of allowed_config_features PR/issue/anything?

The related PR from Notifications is mentioned above since that PR references this one.

@dblock dblock requested a review from saratvemulapalli March 25, 2022 17:27
@qreshi qreshi merged commit 43d6e6d into opensearch-project:main Mar 28, 2022
zelinh pushed a commit that referenced this pull request Aug 18, 2022
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants