-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Upgrade Guava version (#347) #373
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruv16dhr
previously approved these changes
Sep 13, 2023
build.gradle
Outdated
@@ -99,6 +99,7 @@ dependencies { | |||
compile "org.opensearch:common-utils:${common_utils_version}" | |||
configurations.all { | |||
resolutionStrategy { | |||
force "com.google.guava:guava:32.0.1-jre" | |||
force "com.puppycrawl.tools:checkstyle:${project.checkstyle.toolVersion}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcode 10.12.1 here.
Check if build passes.
Arpit-Bandejiya
force-pushed
the
1.3
branch
4 times, most recently
from
September 14, 2023 07:11
d838239
to
3934585
Compare
Signed-off-by: Arpit Bandejiya <[email protected]> (cherry picked from commit 2d8a589)
Arpit-Bandejiya
force-pushed
the
1.3
branch
from
September 14, 2023 07:17
3934585
to
aae7eb2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arpit Bandejiya [email protected]
(cherry picked from commit 2d8a589)
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.