Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses custom plugin to publish zips to maven #150

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jun 7, 2022

Signed-off-by: Surya Sashank Nistala [email protected]

Description

Use custom plugin to publish zips to maven

Issues Resolved

#140

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep requested a review from a team as a code owner June 7, 2022 12:10
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@0b60a3f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5cd13e0 differs from pull request most recent head 462fc29. Consider uploading reports for the commit 462fc29 to get more accurate results

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage        ?   83.51%           
  Complexity      ?      555           
=======================================
  Files           ?       61           
  Lines           ?     2050           
  Branches        ?      146           
=======================================
  Hits            ?     1712           
  Misses          ?      230           
  Partials        ?      108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b60a3f...462fc29. Read the comment docs.

prudhvigodithi
prudhvigodithi previously approved these changes Jun 13, 2022
@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jun 13, 2022

Hey @eirsep you should be adding assemble task to generate the zip task as well.

./gradlew assemble --no-daemon --refresh-dependencies -DskipTests=true -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER
[ -z "$OUTPUT" ] && OUTPUT=artifacts
mkdir -p $OUTPUT/plugins
cp ./build/distributions/*.zip $OUTPUT/plugins

Example PR: opensearch-project/index-management#366
job-scheduler build.sh

Signed-off-by: Surya Sashank Nistala <[email protected]>
@eirsep
Copy link
Member Author

eirsep commented Jun 14, 2022

@prudhvigodithi Addressed your comment.

@dhruv16dhr dhruv16dhr self-requested a review June 15, 2022 06:05
@eirsep eirsep merged commit b81ae03 into opensearch-project:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants